From: Wolfgang Denk Date: Tue, 22 Sep 2009 22:41:45 +0200 Subject: [U-Boot] [PATCH 2/2 v2] Blackfin: tweak embedded env config option In-Reply-To: <200909151736.52720.vapier@gentoo.org> References: <1252511443-1638-2-git-send-email-vapier@gentoo.org> <1252661962-16105-1-git-send-email-vapier@gentoo.org> <20090915204942.DC0A1832E864@gemini.denx.de> <200909151736.52720.vapier@gentoo.org> Message-ID: <20090922204145.02C15832E864@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, In message <200909151736.52720.vapier@gentoo.org> you wrote: > > > ... > > > $(obj)u-boot.ldr: $(obj)u-boot > > > - $(obj)tools/envcrc --binary > $(obj)env-ldr.o > > > + $(CREATE_LDR_ENV) > > > $(LDR) -T $(CONFIG_BFIN_CPU) -c $@ $< $(LDR_FLAGS) > > > > This is all BF specific stuff, right? Maybe we should move this into > > some BF Makefile, then, instead of adding more and more references to > > magic variables that have no meaning anywhere except for BF. > > if you're talking about the %.ldr target, then yes, it is only for Blackfin > systems. it isnt the only target-specific top level which is why it's there > now, but that doesnt mean it has to stay there (as well as the other cruft). > ive already looked at moving this to the Blackfin specific config.mk, but it > would require adding dummy "all" targets early on in the top level Makefile > and one or two subdir Makefiles. i didnt feel like dealing with people > complaining about this. although if we created a new lib_$(ARCH)/targets.mk, > we could push all arch-specific crap there (like all the boards config > targets), and only the top level Makefile would include it. I'm not asking for a general Makefile rework. But maybe we can move this code to some BF Makefile? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "A child is a person who can't understand why someone would give away a perfectly good kitten." - Doug Larson