From: Wolfgang Denk Date: Tue, 22 Sep 2009 22:57:11 +0200 Subject: [U-Boot] [PATCH 1/3] fsl_i2c: Wait for STOP condition to propagate In-Reply-To: <1253178437-32398-1-git-send-email-Joakim.Tjernlund@transmode.se> References: <1253178437-32398-1-git-send-email-Joakim.Tjernlund@transmode.se> Message-ID: <20090922205711.CD894832E864@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Joakim Tjernlund, In message <1253178437-32398-1-git-send-email-Joakim.Tjernlund@transmode.se> you wrote: > After issuing a STOP one must wait until the STOP has completed > on the bus before doing something new to the controller. > > Also add an extra read of SR as the manual mentions doing that > is a good idea. > > Remove surplus write of CR just before a write, isn't required and > could potentially disturb the I2C bus. > > Signed-off-by: Joakim Tjernlund > --- > drivers/i2c/fsl_i2c.c | 12 ++++++++---- > 1 files changed, 8 insertions(+), 4 deletions(-) Could you _please_ start adding some version information to your patches, and a list of changes between the versions? Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Crash programs fail because they are based on the theory that, with nine women pregnant, you can get a baby a month. - Wernher von Braun