From: Mike Frysinger Date: Wed, 23 Sep 2009 11:41:29 -0400 Subject: [U-Boot] [PATCH 2/2 v2] Blackfin: tweak embedded env config option In-Reply-To: <20090922204145.02C15832E864@gemini.denx.de> References: <1252511443-1638-2-git-send-email-vapier@gentoo.org> <200909151736.52720.vapier@gentoo.org> <20090922204145.02C15832E864@gemini.denx.de> Message-ID: <200909231141.29939.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 22 September 2009 16:41:45 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > ... > > > > > > > $(obj)u-boot.ldr: $(obj)u-boot > > > > - $(obj)tools/envcrc --binary > $(obj)env-ldr.o > > > > + $(CREATE_LDR_ENV) > > > > $(LDR) -T $(CONFIG_BFIN_CPU) -c $@ $< $(LDR_FLAGS) > > > > > > This is all BF specific stuff, right? Maybe we should move this into > > > some BF Makefile, then, instead of adding more and more references to > > > magic variables that have no meaning anywhere except for BF. > > > > if you're talking about the %.ldr target, then yes, it is only for > > Blackfin systems. it isnt the only target-specific top level which is > > why it's there now, but that doesnt mean it has to stay there (as well as > > the other cruft). ive already looked at moving this to the Blackfin > > specific config.mk, but it would require adding dummy "all" targets early > > on in the top level Makefile and one or two subdir Makefiles. i didnt > > feel like dealing with people complaining about this. although if we > > created a new lib_$(ARCH)/targets.mk, we could push all arch-specific > > crap there (like all the boards config targets), and only the top level > > Makefile would include it. > > I'm not asking for a general Makefile rework. But maybe we can move > this code to some BF Makefile? well if i'm going to do it for the Blackfin arch, i might as well generalize it and do it the right way the first time ... -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20090923/e57c8ecd/attachment.pgp