From: Niklaus Giger Date: Thu, 24 Sep 2009 10:58:22 +0200 Subject: [U-Boot] [PATCH] ppc4xx: HCU5 board: add register dump In-Reply-To: <1253721550.21888.137.camel@localhost.localdomain> References: <1253719369-26565-1-git-send-email-niklaus.giger@netstal.com> <1253721550.21888.137.camel@localhost.localdomain> Message-ID: <200909241058.22868.niklausgiger@gmx.ch> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Peter Thanks for your feedback, but .. Am Mittwoch 23 September 2009 17:59:10 schrieb Peter Tyser: > Hi Niklaus, > > > + case 0x350: > > + value = mfdcr(0x350); > > + break; > > + case 0x026: > > + value = mfdcr(0x026); > > + break; > > Replace all the above "value = ...; break;" with 1 "value = > mfdcr(ppc440epx_reg[i].address); break;"? This cannot be done, as mfdcr is assembler mfdcr register, ID_OF_DCR ID_OF_DCR cannot be a variable. > > > > > + > > +/* define do_reghcu5 as u-boot command */ > > +U_BOOT_CMD(reghcu5, 2, 1, do_reghcu5, > > + "reghcu5 - print register information for HCU5\n",); > > This command's help message won't be printed correctly. > > Best, > Peter All the rest will show up in the coming next patch. Best regards -- Niklaus Giger Netstal Maschinen AG CH-8752 Naefels