From: Simon Kagstrom Date: Mon, 28 Sep 2009 15:36:38 +0200 Subject: [U-Boot] [PATCH] arm:kirkwood: Add hardware watchdog support for Marvell Kirkwood boards In-Reply-To: <4AC0ADD0.80402@windriver.com> References: <1254121586-26903-1-git-send-email-simon.kagstrom@netinsight.net> <4AC0ADD0.80402@windriver.com> Message-ID: <20090928153638.3067fff2@marrow.netinsight.se> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 28 Sep 2009 07:36:32 -0500 Tom wrote: > > +void hw_watchdog_reset(void) > > +{ > > + unsigned long time = CONFIG_SYS_TCLK * watchdog_timeout; > > > diff --git a/include/asm-arm/arch-kirkwood/cpu.h b/include/asm-arm/arch-kirkwood/cpu.h > > index b3022a3..df49c3f 100644 > > --- a/include/asm-arm/arch-kirkwood/cpu.h > > +++ b/include/asm-arm/arch-kirkwood/cpu.h > > @@ -165,5 +165,7 @@ int kw_config_mpp(unsigned int mpp0_7, unsigned int mpp8_15, > > unsigned int mpp32_39, unsigned int mpp40_47, > > unsigned int mpp48_55); > > unsigned int kw_winctrl_calcsize(unsigned int sizeval); > > +void kw_watchdog_init(unsigned long timeout_secs); > > You should add hw_watchdog_reset to H the file or declare it static. It's a public interface and defined in include/watchdog.h (this is what's being called by WATCHDOG_RESET), but I'll submit a new patch which includes this. > You may want to add #define stubs to handle the ifndef CONFIG_HW_WATCHDOG. I'm afraid I don't understand this comment though, what is the suggestion here? // Simon