From: Jiri Denemark Subject: [PATCH] Fix memory leak in libxenstore python bindings Date: Wed, 30 Sep 2009 14:13:13 +0200 Message-ID: <20090930121313.GA24094@orkuz.home> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="dDRMvlgZJXvWKvBx" Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Temporary tuple0 python object was not freed at the end of xspy_set_permissions() in case no error occurred. To reduce code duplication, this path reuses the cleanup code. Signed-off-by: Jiri Denemark --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="xs-leak.patch" diff -r 6472342c8ab0 tools/python/xen/lowlevel/xs/xs.c --- a/tools/python/xen/lowlevel/xs/xs.c Wed Sep 30 08:51:21 2009 +0100 +++ b/tools/python/xen/lowlevel/xs/xs.c Wed Sep 30 14:08:27 2009 +0200 @@ -324,6 +324,7 @@ static PyObject *xspy_set_permissions(Xs xs_transaction_t th; char *thstr; + PyObject *ret = NULL; if (!xh) goto exit; @@ -380,14 +381,13 @@ static PyObject *xspy_set_permissions(Xs goto exit; } - free(xsperms); Py_INCREF(Py_None); - return Py_None; + ret = Py_None; exit: Py_XDECREF(tuple0); free(xsperms); - return NULL; + return ret; } #define xspy_watch_doc "\n" \ --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --dDRMvlgZJXvWKvBx--