Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MuQiE-00035L-Ao for qemu-devel@nongnu.org; Sun, 04 Oct 2009 09:01:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MuQi9-0002yv-5Y for qemu-devel@nongnu.org; Sun, 04 Oct 2009 09:01:17 -0400 Received: from [199.232.76.173] (port=40829 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MuQi8-0002yl-LQ for qemu-devel@nongnu.org; Sun, 04 Oct 2009 09:01:12 -0400 Received: from imta-38.everyone.net ([216.200.145.38]:54599 helo=omta0105.mta.everyone.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MuQi7-00085n-Uh for qemu-devel@nongnu.org; Sun, 04 Oct 2009 09:01:12 -0400 Date: Sun, 4 Oct 2009 09:01:09 -0400 From: Kevin O'Connor Message-ID: <20091004130109.GA2472@morn.localdomain> References: <20091004090907.GW9832@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091004090907.GW9832@redhat.com> Subject: [Qemu-devel] Re: [PATCH v2][SEABIOS] Move qemu config port access functions into separate file. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org On Sun, Oct 04, 2009 at 11:09:07AM +0200, Gleb Natapov wrote: > > Move qemu config code from smbios.c to its own files. Add support for > -boot menu=on|off qemu option. Thanks Gleb. Please rename the "pv" files - at a minimum to "paravirt", although I think "qemucfg" or "emucfg" is more appropriate. The other thing is new ".c" files need a one line description and a copyright at the top. If you don't care about the copyright then just reuse Fabrice's from smbios.c. If you wish, I can make these changes. -Kevin