From: Simon Kagstrom Date: Mon, 5 Oct 2009 16:40:54 +0200 Subject: [U-Boot] [PATCH] arm926ejs: 16-byte align stack to avoid LDRD/STRD problems In-Reply-To: References: <73173D32E9439E4ABB5151606C3E19E202EF7E99DC@SC-VEXCH1.marvell.com> <20091001182711.26336832E408@gemini.denx.de> <20091005152318.30bc6678@marrow.netinsight.se> Message-ID: <20091005164054.41ac993c@marrow.netinsight.se> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 5 Oct 2009 09:30:54 -0500 Andrew Dyer wrote: > > ? ? ? ?sub ? ? r0, r0, #(CONFIG_STACKSIZE_IRQ+CONFIG_STACKSIZE_FIQ) > > ?#endif > > - ? ? ? sub ? ? sp, r0, #12 ? ? ? ? ? ? /* leave 3 words for abort-stack ? ?*/ > > + ? ? ? sub ? ? sp, r0, #16 ? ? ? ? ? ? /* leave 3 words for abort-stack and */ > > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? /* align stack for ldrd/strd */ > > This doesn't guarantee an alignment. Right above this code is a > series of subtractions by constants, any one of which could throw the > alignment out of whack and be difficult to figure out. > > IMHO it's much safer to do the subtraction to R0, then mask the bottom > address bits out to guarantee alignment, then stuff the results into > sp. Right, new patch coming up. Thanks, // Simon