Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvuEv-0006Re-DX for qemu-devel@nongnu.org; Thu, 08 Oct 2009 10:45:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvuEr-0006Qk-Dc for qemu-devel@nongnu.org; Thu, 08 Oct 2009 10:45:09 -0400 Received: from [199.232.76.173] (port=35707 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvuEr-0006Qh-51 for qemu-devel@nongnu.org; Thu, 08 Oct 2009 10:45:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19974) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvuEq-00038f-LN for qemu-devel@nongnu.org; Thu, 08 Oct 2009 10:45:04 -0400 Date: Thu, 8 Oct 2009 11:44:57 -0300 From: Glauber Costa Subject: Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic Message-ID: <20091008144457.GS8092@mothafucka.localdomain> References: <1254953315-5761-1-git-send-email-glommer@redhat.com> <1254953315-5761-2-git-send-email-glommer@redhat.com> <1254953315-5761-3-git-send-email-glommer@redhat.com> <1254953315-5761-4-git-send-email-glommer@redhat.com> <1254953315-5761-5-git-send-email-glommer@redhat.com> <4ACDEF42.6020706@us.ibm.com> <4ACDF297.9010303@redhat.com> <4ACDF69B.5000000@codemonkey.ws> <4ACDF7DD.1010803@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ACDF7DD.1010803@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm-devel On Thu, Oct 08, 2009 at 04:31:57PM +0200, Avi Kivity wrote: > On 10/08/2009 04:26 PM, Anthony Liguori wrote: >> Avi Kivity wrote: >>> On 10/08/2009 03:55 PM, Anthony Liguori wrote: >>>> >>>> You should probably just setup VMState such that it directly saves >>>> kvm_lapic_state and then have the pre/post functions call the >>>> kernel ioctls to sync it. There's not a whole lot of point >>>> switching the state between two different structures. >>> >>> It ensures the two models are compatible. Since they're the same >>> device from the point of view of the guest, there's no reason for >>> them to have different representations or to be incompatible. >> >> The problem is, the in-kernel apic is not part of the qemu source >> tree. If we add a field to the qemu apic, then we would break the >> in-kernel apic and vice-versa. It's far easier to just have the >> in-kernel apic as a separate model. >> > > You need to handle it anyway due to save/restore; that is the new field > and whatever functionality it has must be optional. Not necessarily. You can grab the structures directly from the kernel definition , copy that over, issue the ioctl, and just make sure the source and destination have compatible kernels.