From: Jan Kara Subject: Re: [PATCH 01/45] writeback: reduce calls to global_page_state in balance_dirty_pages() Date: Fri, 9 Oct 2009 17:47:59 +0200 Message-ID: <20091009154759.GJ7654@duck.suse.cz> References: <20091007073818.318088777@intel.com> <20091007074901.251116016@intel.com> <20091009151230.GF7654@duck.suse.cz> <1255101512.8802.65.camel@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Wu Fengguang , Andrew Morton , Theodore Tso , Christoph Hellwig , Dave Chinner , Chris Mason , Li Shaohua , Myklebust Trond , "jens.axboe@oracle.com" , Nick Piggin , linux-fsdevel@vger.kernel.org, Richard Kennedy , LKML To: Peter Zijlstra Return-path: Content-Disposition: inline In-Reply-To: <1255101512.8802.65.camel@laptop> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri 09-10-09 17:18:32, Peter Zijlstra wrote: > On Fri, 2009-10-09 at 17:12 +0200, Jan Kara wrote: > > Ugh, but this is not equivalent! We would block the writer on some BDI > > without any dirty data if we are over global dirty limit. That didn't > > happen before. > > It should have, we should throttle everything calling > balance_dirty_pages() when we're over the total limit. OK :) I agree it's reasonable. But Wu, please note this in the changelog because it might be a substantial change for some loads. Honza -- Jan Kara SUSE Labs, CR