Received: from mx3.mail.elte.hu ([157.181.1.138]) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1MxIsc-0003sl-Eq for linux-mtd@lists.infradead.org; Mon, 12 Oct 2009 11:15:59 +0000 Date: Mon, 12 Oct 2009 13:15:45 +0200 From: Ingo Molnar To: Artem Bityutskiy Subject: Re: [PATCH] panic.c: export panic_on_oops Message-ID: <20091012111545.GB8857@elte.hu> References: <1255241458-11665-1-git-send-email-dedekind1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1255241458-11665-1-git-send-email-dedekind1@gmail.com> Cc: Artem Bityutskiy , LKML , Aaro Koskinen , linux-mtd , Simon Kagstrom , Andrew Morton , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Artem Bityutskiy wrote: > From: Artem Bityutskiy > > We use the mtdoops module which stores oopses on the Flash partition, > in order to make it possible to analyze them later. And mtdoops needs > to know whether 'panic_on_oops' is on or off. Thus, we need this > variable to be exported. hm, why does it need it? Could you send the patch please that makes use of it (as an easy way to explain the need for the export) - current upstream drivers/mtd/mtdoops.c doesnt need it so it must be some pending change. Ingo