Received: from ernst.netinsight.se ([194.16.221.21]) by bombadil.infradead.org with smtp (Exim 4.69 #1 (Red Hat Linux)) id 1MxIzc-0007pu-PL for linux-mtd@lists.infradead.org; Mon, 12 Oct 2009 11:23:12 +0000 Date: Mon, 12 Oct 2009 13:23:04 +0200 From: Simon Kagstrom To: Ingo Molnar Subject: Re: [PATCH] panic.c: export panic_on_oops Message-ID: <20091012132304.52d4646c@marrow.netinsight.se> In-Reply-To: <20091012111545.GB8857@elte.hu> References: <1255241458-11665-1-git-send-email-dedekind1@gmail.com> <20091012111545.GB8857@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Artem Bityutskiy , Artem Bityutskiy , LKML , Aaro Koskinen , linux-mtd , Andrew Morton , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 12 Oct 2009 13:15:45 +0200 Ingo Molnar wrote: > * Artem Bityutskiy wrote: > > > We use the mtdoops module which stores oopses on the Flash partition, > > in order to make it possible to analyze them later. And mtdoops needs > > to know whether 'panic_on_oops' is on or off. Thus, we need this > > variable to be exported. > > hm, why does it need it? Could you send the patch please that makes use > of it (as an easy way to explain the need for the export) - current > upstream drivers/mtd/mtdoops.c doesnt need it so it must be some pending > change. You have the patch that requires it here: http://patchwork.ozlabs.org/patch/34732/ it's a fix to allow mtdoops to actually store oopses which happen when panic_on_oops is set (before these would be missed as the write would never be done). // Simon