Received: from mx3.mail.elte.hu ([157.181.1.138]) by bombadil.infradead.org with esmtps (Exim 4.69 #1 (Red Hat Linux)) id 1Myhsl-0003Cc-Ai for linux-mtd@lists.infradead.org; Fri, 16 Oct 2009 08:09:55 +0000 Date: Fri, 16 Oct 2009 10:09:35 +0200 From: Ingo Molnar To: Simon Kagstrom Subject: Re: [PATCH v9 4/5] core: Add kernel message dumper to call on oopses and panics Message-ID: <20091016080935.GA3895@elte.hu> References: <20091015094057.7298e0d7@marrow.netinsight.se> <20091015094805.754461fa@marrow.netinsight.se> <20091015093133.GF10546@elte.hu> <20091015161052.0752208e@marrow.netinsight.se> <20091015154640.GA11408@elte.hu> <20091016094601.4e2c2d3e@marrow.netinsight.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091016094601.4e2c2d3e@marrow.netinsight.se> Cc: Artem Bityutskiy , David Woodhouse , LKML , "Koskinen Aaro \(Nokia-D/Helsinki\)" , linux-mtd , Andrew Morton , Linus Torvalds , Alan Cox List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , * Simon Kagstrom wrote: /** * kmsg_dump_register - register a kernel log dumper. * @dump: pointer to the kmsg_dumper structure * * Adds a kernel log dumper to the system. The dump callback in the * structure will be called when the kernel oopses or panics and must be * set. Returns zero on success and -EINVAL or -EBUSY otherwise. */ Small detail - please use the KernelDoc style used in existing printk.c facilities, i.e. use a single space instead of a tab: /** * kmsg_dump_register - register a kernel log dumper. * @dump: pointer to the kmsg_dumper structure * * Adds a kernel log dumper to the system. The dump callback in the * structure will be called when the kernel oopses or panics and must be * set. Returns zero on success and -EINVAL or -EBUSY otherwise. */ (in the other functions as well) Ingo