From: Wolfgang Denk Date: Sun, 18 Oct 2009 22:57:17 +0200 Subject: [U-Boot] [PATCH] mem_mtest: fix error reporting, allow escape with ^C In-Reply-To: <1254521913-25655-1-git-send-email-paul.gortmaker@windriver.com> References: <4AC5438B.903@windriver.com> <1254521913-25655-1-git-send-email-paul.gortmaker@windriver.com> Message-ID: <20091018205717.8FBDF3F6CE@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Paul Gortmaker, In message <1254521913-25655-1-git-send-email-paul.gortmaker@windriver.com> you wrote: > The basic memtest function tries to watch for ^C after each > pattern pass as an escape mechanism, but if things are horribly > wrong, we'll be stuck in an inner loop flooding the console with > error messages and never check for ^C. To make matters worse, > if the user waits for all the error messages to complete, we > then incorrectly report the test passed without errors. > > Adding a check for ^C after any error is printed will give > the end user an escape mechanism from a console flood without > slowing down the overall test speed on a slow processor. > > Also, the more extensive memtest quit after just a single error, > which is inconsistent with the normal memtest, and not useful if > if you are doing dynamic environmental impact testing, such as > heating/cooling etc. > > Both tests now track the error count and report it properly > at test completion. > > Signed-off-by: Paul Gortmaker > --- > > Changes: fixed return values since prev. version. > > common/cmd_mem.c | 58 ++++++++++++++++++++++++++++++++++++++++------------- > 1 files changed, 44 insertions(+), 14 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Bus error -- please leave by the rear door.