From: Wolfgang Denk Date: Tue, 20 Oct 2009 00:33:58 +0200 Subject: [U-Boot] [PATCH 1/2] Don't let the command-line ARCH=powerpc override our redefinition to ppc. In-Reply-To: <20091019212409.GA31322@loki.buserror.net> References: <20091019212409.GA31322@loki.buserror.net> Message-ID: <20091019223358.88B0FC88C4@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Scott Wood, In message <20091019212409.GA31322@loki.buserror.net> you wrote: > The override keyword is needed for make to take our version over the one > specified on the command line, and remove it from the list of command line > overrides that are passed to submakes. IMHO, the combination of "export" > and "override" ought to do this automatically, but oh well. I have to admit that I don't see the problem. When I explicitly ask for a specific ARCH setting on the command line (versus using some setting I inherited from the envrionment, eventually even unaware of the current value), then I do want to use that. So the current code seems to do what I would expect from it. Maybe my expectations are whacky, though. I tend to NAK this one. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I was playing poker the other night... with Tarot cards. I got a full house and 4 people died. - Steven Wright