From: Wolfgang Denk Date: Tue, 20 Oct 2009 00:35:14 +0200 Subject: [U-Boot] [PATCH 2/2] tools: Use override when changing CC, CFLAGS, etc. In-Reply-To: <20091019212435.GA31339@loki.buserror.net> References: <20091019212435.GA31339@loki.buserror.net> Message-ID: <20091019223514.7CC65C88C5@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Scott Wood, In message <20091019212435.GA31339@loki.buserror.net> you wrote: > If the user has specified a CC or similar on the command line, that is the > cross compiler, not the host compiler. Override is needed to keep these > assignments from being ignored in that case. > > Signed-off-by: Scott Wood > --- > tools/Makefile | 10 +++++----- > tools/gdb/Makefile | 6 +++--- > 2 files changed, 8 insertions(+), 8 deletions(-) As Mike pointed out, we should rather consistently use HOSTCC when we refer to the host's C compiler. I suggest you rework the patch to do that. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Swap read error. You lose your mind.