From: Tim Deegan Subject: Re: Re: [PATCH] Update cr3 in PAE mode when guest walk succeed but shadow walk fails Date: Wed, 21 Oct 2009 10:50:06 +0100 Message-ID: <20091021095006.GI20579@whitby.uk.xensource.com> References: <4ADED858.6070201@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Return-path: Content-Disposition: inline In-Reply-To: <4ADED858.6070201@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Paolo Bonzini Cc: George Dunlap , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Hi, At 10:46 +0100 on 21 Oct (1256121960), Paolo Bonzini wrote: > I suppose this patch is also needed when running 32-on-64. In that > case, shouldn't the test be > > #if GUEST_PAGING_LEVELS >= 3 > > rather than "== 3"? No, '==' is correct. GUEST_PAGING_LEVELS refers to the layout of the _guest's_ pagetables, not the shadows. GUEST_PAGING_LEVELS == 4 means the guest is using full 64-bit pagetables, which don't have this quirk. Cheers, Tim, -- Tim Deegan Principal Software Engineer, Citrix Systems (R&D) Ltd. [Company #02300071, SL9 0DZ, UK.]