Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0cEw-0002ds-VM for qemu-devel@nongnu.org; Wed, 21 Oct 2009 10:32:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0cEr-0002aV-Ul for qemu-devel@nongnu.org; Wed, 21 Oct 2009 10:32:38 -0400 Received: from [199.232.76.173] (port=41002 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0cEr-0002aQ-Qb for qemu-devel@nongnu.org; Wed, 21 Oct 2009 10:32:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6402) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N0cEr-0006SF-9H for qemu-devel@nongnu.org; Wed, 21 Oct 2009 10:32:33 -0400 Date: Wed, 21 Oct 2009 12:32:28 -0200 From: Glauber Costa Subject: Re: [Qemu-devel] [PATCH] properly save kvm system time msr registers Message-ID: <20091021143228.GD8092@mothafucka.localdomain> References: <1256047441-9846-1-git-send-email-glommer@redhat.com> <4ADF0ED7.8000706@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ADF0ED7.8000706@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: aliguori@us.ibm.com, Marcelo Tosatti , qemu-devel@nongnu.org On Wed, Oct 21, 2009 at 03:38:31PM +0200, Gerd Hoffmann wrote: > On 10/20/09 16:04, Glauber Costa wrote: >> Currently, the msrs involved in setting up pvclock are not saved over >> migration and/or save/restore. This patch puts their value in special >> fields in our CPUState, and deal with them using vmstate. >> >> kvm also has to account for it, by including them in the msr list >> for the ioctls. > > Fails to build. Fedora 11 machine with distro kernel. > > http://repo.or.cz/w/qemu/pdb.git?a=blob;f=build.log;h=5b8a2e83116dc6a74e5045e30c3efe71fa7397ef;hb=0b4f913c89b89b45d3844dc1cf321e3d94871ecb strange message. Do we need --kerneldir for that? kvm_para.h should be available...