Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N14gv-0002xN-Sz for qemu-devel@nongnu.org; Thu, 22 Oct 2009 16:55:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N14gu-0002vg-CN for qemu-devel@nongnu.org; Thu, 22 Oct 2009 16:55:25 -0400 Received: from [199.232.76.173] (port=53662 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N14gu-0002vY-22 for qemu-devel@nongnu.org; Thu, 22 Oct 2009 16:55:24 -0400 Received: from hall.aurel32.net ([88.191.82.174]:37905) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N14gt-0000Z9-KB for qemu-devel@nongnu.org; Thu, 22 Oct 2009 16:55:23 -0400 Date: Thu, 22 Oct 2009 22:55:18 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] target-arm: log instructions start in TCG code Message-ID: <20091022205518.GN1883@hall.aurel32.net> References: <20091015215157.GD7071@volta.aurel32.net> <761ea48b0910180729v7f277b02n641715865688f77@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <761ea48b0910180729v7f277b02n641715865688f77@mail.gmail.com> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Desnogues Cc: qemu-devel@nongnu.org On Sun, Oct 18, 2009 at 04:29:52PM +0200, Laurent Desnogues wrote: > On Thu, Oct 15, 2009 at 11:51 PM, Aurelien Jarno wrote: > > Signed-off-by: Aurelien Jarno > > --- > >  target-arm/translate.c |    4 ++++ > >  1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/target-arm/translate.c b/target-arm/translate.c > > index 0c10ac2..bb0f8ef 100644 > > --- a/target-arm/translate.c > > +++ b/target-arm/translate.c > > @@ -8805,6 +8805,10 @@ static inline void gen_intermediate_code_internal(CPUState *env, > >         if (num_insns + 1 == max_insns && (tb->cflags & CF_LAST_IO)) > >             gen_io_start(); > > > > +        if (unlikely(qemu_loglevel_mask(CPU_LOG_TB_OP))) { > > +            tcg_gen_debug_insn_start(dc->pc); > > +        } > > + > >         if (env->thumb) { > >             disas_thumb_insn(env, dc); > >             if (dc->condexec_mask) { > > -- > > 1.6.1.3 > > Shouldn't you dump the TCG debug instruction before the > check for gen_io_start? > Good question. I have mainly added this debug code at the same location as on other architecture. The question is does the gen_io code actually belong to an op? -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net