From: Mike Frysinger Date: Sun, 25 Oct 2009 01:32:26 -0400 Subject: [U-Boot] [PATCH 3/5] readline(): Add ability to modify a string buffer In-Reply-To: <4AE375EF.7060401@xes-inc.com> References: <1256259563-32725-1-git-send-email-ptyser@xes-inc.com> <20091024172619.98009185D4A5@gemini.denx.de> <4AE375EF.7060401@xes-inc.com> Message-ID: <200910250132.28174.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 24 October 2009 17:47:27 Peter Tyser wrote: > Wolfgang Denk wrote: > > Peter Tyser wrote: > >> If the 'buf' parameter is a non-0-length string, its contents will be > >> edited. Previously, the initial value of 'buf' was ignored and the > >> user entered its contents from scratch. > > > > What is the purpose of this modification? Are you fixing a bug (which > > one?) or implementing an extension (which one) or what? > > This change was necessary to add a new "editenv" command. This change > allows the readline() function to edit a string instead of just enter > one from scratch. In theory this feature could be used for other areas > of U-Boot in the future, but at this point the only user of it would be > the "editenv" command which I submitted a patch for. If the 'editenv' > patch is rejected, I don't mind this one being rejected too. +1 from me for new "editenv" :) -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20091025/9679bbec/attachment.pgp