From: Wolfgang Denk Date: Sun, 25 Oct 2009 21:14:15 +0100 Subject: [U-Boot] [PATCH 1/2 v4] env: only build env_embedded and envcrc when needed In-Reply-To: <200910182055.01744.vapier@gentoo.org> References: <1252498455-28276-1-git-send-email-vapier@gentoo.org> <200910181701.33654.vapier@gentoo.org> <20091018213215.193873F6CE@gemini.denx.de> <200910182055.01744.vapier@gentoo.org> Message-ID: <20091025201415.C32ED4C028@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, In message <200910182055.01744.vapier@gentoo.org> you wrote: > > > This patch seems to break a *lot* of boards: > > i'm attaching two patches here. since we're past the merge window but before > rc1, i dont know how invasive you want to get. > > the first one restores env_embedded.o building for certain config options > (even though it'll only produce a 0 byte file). if you want to be cautious > for this release, then i guess we can merge just this patch. > > the second one attempts to clean up env_embedded.o in all linker scripts where > the board would only end up with a 0 byte file. obviously i cant test any of > these since i dont have the hardware, but the logic seems straight forward. > if you want to stay cautious, this would go into the next branch for start of > next merge window. > > or just merge the 2nd patch only and assume that people who dont test the rc1+ > are dead boards anyways. i got some build errors even after these fixes, but > they seem unrelated to my env_embedded changes as they have to do with > sections filling up & overflowing with my gcc-4.1.1 compiler. > -mike Applied patch #2, after testing on lwmon. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Do not simplify the design of a program if a way can be found to make it complex and wonderful.