From: Wolfgang Denk Date: Fri, 30 Oct 2009 09:26:12 +0100 Subject: [U-Boot] [PATCH] Davinci: add a pin multiplexer configuration API In-Reply-To: <20091029182304.469c9f7f.kim.phillips@freescale.com> References: <4AE9B6EA.9080206@gefanuc.com> <20091029182304.469c9f7f.kim.phillips@freescale.com> Message-ID: <20091030082612.62AFCC88C8@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Kim Phillips, In message <20091029182304.469c9f7f.kim.phillips@freescale.com> you wrote: > > > + if (field < PIN_MUX_NUM_FIELDS && > > + (value & ~PIN_MUX_FIELD_MASK) == 0) { > > the second line should not be indented as though it is the code > subblock; it should fall directly underneath the column where 'field > <..' starts, like this: Agreed. > if (field < PIN_MUX_NUM_FIELDS && > (value & ~PIN_MUX_FIELD_MASK) == 0) { > > > + int offset = field * PIN_MUX_FIELD_SIZE; > > + unsigned int mux = pins[i].mux; > > + unsigned int mask = PIN_MUX_FIELD_MASK << offset; > > also please just declare everything at the top of the function - same > for value and field declarations above. No! Why should that be needed? It would be just a waste of stack space (except that recent compilers don't care abouyt this anyway), and keeping variables as localized as possible seems to be a good thing to me. > > + value <<= offset; > > + writel(value | (readl(mux) & (~mask)), mux); > > I guess arm doesn't have setbits32 and friends, huh. Not yet. Patches welcome! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Evil does seek to maintain power by suppressing the truth." "Or by misleading the innocent." -- Spock and McCoy, "And The Children Shall Lead", stardate 5029.5.