From: Jan Blunck Subject: Re: [RFC 1/3] BKL pushdown from do_new_mount() to the filesystems Date: Sat, 31 Oct 2009 13:26:08 +0100 Message-ID: <20091031122608.GB22999@T61.lan> References: <1254324604-20243-1-git-send-email-jblunck@suse.de> <1254324604-20243-2-git-send-email-jblunck@suse.de> <4ACE0A0C.2030701@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Boaz Harrosh Return-path: Received: from charybdis-ext.suse.de ([195.135.221.2]:49624 "EHLO emea5-mh.id5.novell.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757698AbZJaM0F (ORCPT ); Sat, 31 Oct 2009 08:26:05 -0400 Content-Disposition: inline In-Reply-To: <4ACE0A0C.2030701@panasas.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Oct 08, Boaz Harrosh wrote: > Jan Blunck wrote > > diff --git a/fs/exofs/super.c b/fs/exofs/super.c > > index 9f500de..ea045b8 100644 > > --- a/fs/exofs/super.c > > +++ b/fs/exofs/super.c > > @@ -297,9 +297,13 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) > > struct osd_obj_id obj; > > int ret; > > > > + lock_kernel(); > > + > > sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); > > - if (!sbi) > > + if (!sbi) { > > + unlock_kernel(); > > return -ENOMEM; > > + } > > sb->s_fs_info = sbi; > > > > /* use mount options to fill superblock */ > > @@ -399,6 +403,7 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) > > out: > > if (or) > > osd_end_request(or); > > + unlock_kernel(); > > return ret; > > > > free_sbi: > > You can add the revert of this patch to your series when submitted. > We don't need the BKL in exofs. > > Signed-off-by: Boaz Harrosh > Thanks Boaz. I've added it to my series. Cheers, Jan > @@ -297,13 +297,9 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) > struct osd_obj_id obj; > int ret; > > - lock_kernel(); > - > sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); > - if (!sbi) { > - unlock_kernel(); > + if (!sbi) > return -ENOMEM; > - } > sb->s_fs_info = sbi; > > /* use mount options to fill superblock */ > @@ -399,7 +403,6 @@ static int exofs_fill_super(struct super_block *sb, void *data, int silent) > out: > if (or) > osd_end_request(or); > - unlock_kernel(); > return ret; > > free_sbi: