From: Wolfgang Denk Date: Sat, 31 Oct 2009 16:23:43 +0100 Subject: [U-Boot] Best way of making some drivers common across kirkwood and orion5x SoCs? In-Reply-To: <4AEC53DB.6050509@free.fr> References: <4AEBFF60.90902@free.fr> <20091031145030.8B687C88C7@gemini.denx.de> <4AEC53DB.6050509@free.fr> Message-ID: <20091031152343.CCBFBC88C7@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Albert ARIBAUD, In message <4AEC53DB.6050509@free.fr> you wrote: > > Would a name such as "marvell.h" be more acceptable? This would be Hm... I expect there will be little chance to see MAarvell IP blocks in non-Marvell SoCs, so this should work indeed. On the other hand, why not chose a name that works for other CPUs / SoCs as well. [So on second thought maybe your "soc.h" was not that bad a name.] Let's see what others suggest. > consistent with my intent to replace kirkwood references with marvell > ones in all non-kirkwood-specific symbols, e.g. kikwood_egiga_initialize > would become marvell_egiga_initialize etc. Do we need this "kirkwood_" or "marvell_" prefix at all? Where e4lse do we expect to see for example "egiga_" show up? We do not use "intel_e1000_..." or "realtek_rtl8139_..." etc. either, Just drop that part. Nobody will miss it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Our way is peace. -- Septimus, the Son Worshiper, "Bread and Circuses", stardate 4040.7.