Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N52MF-0002hU-FV for mharc-grub-devel@gnu.org; Mon, 02 Nov 2009 14:14:27 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N52MD-0002hJ-J5 for grub-devel@gnu.org; Mon, 02 Nov 2009 14:14:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N52MA-0002gi-1M for grub-devel@gnu.org; Mon, 02 Nov 2009 14:14:25 -0500 Received: from [199.232.76.173] (port=43067 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N52M9-0002gf-SN for grub-devel@gnu.org; Mon, 02 Nov 2009 14:14:21 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:41054 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N52M9-0005fB-HL for grub-devel@gnu.org; Mon, 02 Nov 2009 14:14:21 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1N52Lx-0002zW-G8 for grub-devel@gnu.org; Mon, 02 Nov 2009 20:14:09 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1N52M0-000335-5U for grub-devel@gnu.org; Mon, 02 Nov 2009 20:14:12 +0100 Date: Mon, 2 Nov 2009 20:14:12 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20091102191412.GB11570@thorin> References: <20091102023334.GD4557@const.famille.thibault.fr> <20091102135202.GD7765@thorin> <20091102172858.GY5001@const.bordeaux.inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20091102172858.GY5001@const.bordeaux.inria.fr> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH,HURD] Fix GNU/Hurd partition number X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2009 19:14:25 -0000 On Mon, Nov 02, 2009 at 06:28:58PM +0100, Samuel Thibault wrote: > Robert Millan, le Mon 02 Nov 2009 14:52:02 +0100, a écrit : > > On Mon, Nov 02, 2009 at 03:33:34AM +0100, Samuel Thibault wrote: > > > * util/hostdisk.c (grub_util_biosdisk_get_grub_dev): Subtract 1 from > > > GNU partition number to get internal grub DOS partition number. > > > > Are you sure this is needed? We use the same numbering scheme as GNU/Hurd. > > (hd0,1) means first partition, so does /dev/hd0s1. > > Externally, yes. > Internally, no, cf make_device_name: > > if (dos_part >= 0) > sprintf (p + strlen (p), ",%d", dos_part + 1); > > so from hd0s1 I need to provide dos_part==0 in order to get (hd0,1). Oh, ok. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."