From: Wolfgang Denk Date: Tue, 03 Nov 2009 14:28:13 +0100 Subject: [U-Boot] [PATCH 08/10] ARM Add New Board GEC2410 In-Reply-To: References: <4d24675049ec9c1489eb78aa5e7525c9a1887eba.1256898456.git.zetalabs@gmail.com> <6c7a9a5dcafb1f535ed33cb29d579db993846325.1256898456.git.zetalabs@gmail.com> <28c8c0b4de93d8f48e61ff560c4537768b4e1455.1256898456.git.zetalabs@gmail.com> <20091031201507.9F75EC88C7@gemini.denx.de> Message-ID: <20091103132813.B7DA43F6EC@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Hui Tang, In message you wrote: > Dear Wolfgang, > > >> - printf("s3c2410_nand_correct_data: not implemented\n"); > >> + debugX(1, "s3c2410_nand_correct_data: not implemented\n"); > > > > I think this should remain a printf(). > > Since when booting from nand flash, the printf() is not available in > the early stage, here I replace printf() with debugX() to avoid using > the undefined function. But this is wrong. When you enable debuging, the same problem would be present again. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "If that makes any sense to you, you have a big problem." -- C. Durance, Computer Science 234