Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5YJm-0008Kv-6r for qemu-devel@nongnu.org; Wed, 04 Nov 2009 00:22:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5YJh-0008KP-Kh for qemu-devel@nongnu.org; Wed, 04 Nov 2009 00:22:01 -0500 Received: from [199.232.76.173] (port=56712 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5YJh-0008KM-Fb for qemu-devel@nongnu.org; Wed, 04 Nov 2009 00:21:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14542) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N5YJh-0003Xc-38 for qemu-devel@nongnu.org; Wed, 04 Nov 2009 00:21:57 -0500 Date: Wed, 4 Nov 2009 10:51:13 +0530 From: Amit Shah Message-ID: <20091104052113.GA27028@amit-x200.redhat.com> References: <1257258596-4556-1-git-send-email-amit.shah@redhat.com> <1257258596-4556-2-git-send-email-amit.shah@redhat.com> <1257258596-4556-3-git-send-email-amit.shah@redhat.com> <4AF063A9.7000908@siemens.com> <20091103175552.GA25029@amit-x200.redhat.com> <20091103180934.GA25423@amit-x200.redhat.com> <4AF07C37.9040904@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AF07C37.9040904@web.de> Subject: [Qemu-devel] Re: [PATCH 2/3] char: Remove special init_reset handling List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org On (Tue) Nov 03 2009 [19:53:43], Jan Kiszka wrote: > Amit Shah wrote: > > On (Tue) Nov 03 2009 [23:25:52], Amit Shah wrote: > >> On (Tue) Nov 03 2009 [18:08:57], Jan Kiszka wrote: > >>> Amit Shah wrote: > >>>> The initial_reset sent to chardevs doesn't do much other than setting > >>>> a bool to true. Char devices are interested in the open event and > >>>> that gets sent whenever the device is opened. > >>> Have you checked with the monitor in all use cases (dedicated & muxed > >>> console, stdio & SDL console, etc.)? It was introduced once to fix a > >> I've checked with -monitor stdio, monitor in SDL and also chardevs using > >> unix sockets. > >> > >> I've not tried mux yet; I'll try that and report back. BTW if it ends up > >> not working with this patch, it'd be broken in the current master as > >> well. > > > > I tried with: > > > > -chardev stdio,mux=on,id=mux -monitor chardev:mux -serial chardev:mux > > > > The monitor prompt shows up as does the serial output. > > > > (btw I've also tried closing and opening char devs and that works fine > > too) > > That sounds good. Then something must have changed since 2970a6c943, do > you see what? I think that depended on the resets being sent. I've now removed the need for resets altogether. Amit