From: Yolkfull Chow Subject: Re: [Autotest] [KVM-AUTOTEST PATCH 7/7] KVM test: remove monitor socket file when destroying a VM Date: Fri, 6 Nov 2009 11:14:04 +0800 Message-ID: <20091106031404.GB2441@aFu.nay.redhat.com> References: <1257415272-9423-1-git-send-email-mgoldish@redhat.com> <1257415272-9423-2-git-send-email-mgoldish@redhat.com> <1257415272-9423-3-git-send-email-mgoldish@redhat.com> <1257415272-9423-4-git-send-email-mgoldish@redhat.com> <1257415272-9423-5-git-send-email-mgoldish@redhat.com> <1257415272-9423-6-git-send-email-mgoldish@redhat.com> <1257415272-9423-7-git-send-email-mgoldish@redhat.com> Reply-To: Yolkfull Chow Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Michael Goldish Return-path: Received: from mx1.redhat.com ([209.132.183.28]:2229 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755190AbZKFDOC (ORCPT ); Thu, 5 Nov 2009 22:14:02 -0500 Content-Disposition: inline In-Reply-To: <1257415272-9423-7-git-send-email-mgoldish@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Nov 05, 2009 at 12:01:12PM +0200, Michael Goldish wrote: > This should slow the rate of accumulation of monitor files in /tmp. Hi Michael, I recommend we use TCP as monitor dev of VM. Two reasons: 1) we don't need to add extra code to remove monitor files 2) it's necessary for some users want to implement client-side migration. What do you think? ;-) > > Signed-off-by: Michael Goldish > --- > client/tests/kvm/kvm_vm.py | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py > index 5781dbc..62a10b9 100755 > --- a/client/tests/kvm/kvm_vm.py > +++ b/client/tests/kvm/kvm_vm.py > @@ -578,6 +578,10 @@ class VM: > finally: > if self.process: > self.process.close() > + try: > + os.unlink(self.monitor_file_name) > + except OSError: > + pass > > > def is_alive(self): > -- > 1.5.4.1 > > _______________________________________________ > Autotest mailing list > Autotest@test.kernel.org > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest