From: Jan Blunck Subject: Re: [PATCH 1/2] BKL: Remove BKL from default_llseek() Date: Wed, 18 Nov 2009 18:55:40 +0100 Message-ID: <20091118175540.GR21750@bolzano.suse.de> References: <1258560457-15129-1-git-send-email-jblunck@suse.de> <20091118171524.4d2f8cec@lxorguk.ukuu.org.uk> <20091118172730.GD28723@shareable.org> <200911181835.55007.oliver@neukum.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jamie Lokier , Alan Cox , linux-fsdevel@vger.kernel.org, Linux-Kernel Mailinglist , Andrew Morton , jkacur@redhat.com, Thomas Gleixner , Arnd Bergmann , Christoph Hellwig , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Alexander Viro To: Oliver Neukum Return-path: Received: from cantor.suse.de ([195.135.220.2]:43551 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932142AbZKRRzf (ORCPT ); Wed, 18 Nov 2009 12:55:35 -0500 Content-Disposition: inline In-Reply-To: <200911181835.55007.oliver@neukum.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Nov 18, Oliver Neukum wrote: > Am Mittwoch, 18. November 2009 18:27:30 schrieb Jamie Lokier: > > > No. Your logic is flawed > > > > > > The BKL is protected something here - it protects the change of offset > > > with respect to other BKL users within drivers. The question is what if > > > anything in any other driver code depends upon the BKL and uses it to > > > protect f_pos. Probably very little if anything but a grep for f_pos > > > through the drivers might not be a bad idea before assuming this. Very > > > few touch f_pos except in their own llseek method. > > > > Of course, drivers shouldn't be using f_pos outside their llseek > > method, as they should all behave the same with pread/pwrite as with > > llseek+read/write. > > Might not a driver update f_pos after read/write? Actually the VFS is doing that for you in read/write syscall. So anything you change in your driver gets corrected (or overwritten anyway). Regards, Jan -- Jan Blunck