From: Arnd Bergmann Subject: Re: [PATCH 1/2] BKL: Remove BKL from default_llseek() Date: Wed, 18 Nov 2009 18:33:37 +0100 Message-ID: <200911181833.37531.arnd@arndb.de> References: <1258560457-15129-1-git-send-email-jblunck@suse.de> <20091118171524.4d2f8cec@lxorguk.ukuu.org.uk> <20091118172730.GD28723@shareable.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Alan Cox , Jan Blunck , linux-fsdevel@vger.kernel.org, "Linux-Kernel Mailinglist" , Andrew Morton , jkacur@redhat.com, Thomas Gleixner , Christoph Hellwig , =?iso-8859-1?q?Fr=E9d=E9ric_Weisbecker?= , Alexander Viro To: Jamie Lokier Return-path: In-Reply-To: <20091118172730.GD28723@shareable.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wednesday 18 November 2009, Jamie Lokier wrote: > Alan Cox wrote: > > > Using the BKL in llseek() does not protect the inode's i_size from > > > modification since the i_size is protected by a seqlock nowadays. Since > > > default_llseek() is already using the i_size_read() wrapper it is not the > > > BKL which is serializing the access here. > > > The access to file->f_pos is not protected by the BKL either since its > > > access in vfs_write()/vfs_read() is not protected by any lock. If the BKL > > > is not protecting anything here it can clearly get removed. > > > > No. Your logic is flawed > > > > The BKL is protected something here - it protects the change of offset > > with respect to other BKL users within drivers. The question is what if > > anything in any other driver code depends upon the BKL and uses it to > > protect f_pos. Probably very little if anything but a grep for f_pos > > through the drivers might not be a bad idea before assuming this. Very > > few touch f_pos except in their own llseek method. > > Of course, drivers shouldn't be using f_pos outside their llseek > method, as they should all behave the same with pread/pwrite as with > llseek+read/write. > > Is that mistaken? There are drivers touching f_pos in ioctl() methods, which is vaguely reasonable. There are also driver touching it in their read()/write() methods, which has no effect whatsoever. I started grepping through the kernel trying to find any instances of the first case that uses the BKL, but I only found three instances of the second case and got heavily demotivated by that. Arnd <><