Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NAppW-00083v-5i for qemu-devel@nongnu.org; Wed, 18 Nov 2009 14:04:38 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NAppT-00083Q-Lk for qemu-devel@nongnu.org; Wed, 18 Nov 2009 14:04:37 -0500 Received: from [199.232.76.173] (port=50701 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NAppT-00083N-HK for qemu-devel@nongnu.org; Wed, 18 Nov 2009 14:04:35 -0500 Received: from verein.lst.de ([213.95.11.210]:53027) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1NAppS-0006I9-NI for qemu-devel@nongnu.org; Wed, 18 Nov 2009 14:04:35 -0500 Date: Wed, 18 Nov 2009 20:04:33 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] posix-aio-compat: Fix error check Message-ID: <20091118190433.GB29881@lst.de> References: <1258542910-724-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1258542910-724-1-git-send-email-kwolf@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Wed, Nov 18, 2009 at 12:15:10PM +0100, Kevin Wolf wrote: > Checking for nbytes < 0 is pointless as long as it's a size_t. If we want to > use negative numbers for error codes, we should use signed types. Indeed, patch looks good. Reviewed-by: Christoph Hellwig