From: Arnd Bergmann Subject: Re: [PATCH 1/2] BKL: Remove BKL from default_llseek() Date: Wed, 18 Nov 2009 19:06:59 +0100 Message-ID: <200911181906.59367.arnd@arndb.de> References: <1258560457-15129-1-git-send-email-jblunck@suse.de> <200911181833.37531.arnd@arndb.de> <20091118180044.3d5981bf@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Jamie Lokier , Jan Blunck , linux-fsdevel@vger.kernel.org, "Linux-Kernel Mailinglist" , Andrew Morton , jkacur@redhat.com, Thomas Gleixner , Christoph Hellwig , =?iso-8859-1?q?Fr=E9d=E9ric_Weisbecker?= , Alexander Viro To: Alan Cox Return-path: In-Reply-To: <20091118180044.3d5981bf@lxorguk.ukuu.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wednesday 18 November 2009, Alan Cox wrote: > > There are drivers touching f_pos in ioctl() methods, which is vaguely > > reasonable. There are also driver touching it in their read()/write() > > methods, which has no effect whatsoever. > > osst is the obvious offender. The ioctl ones like mtdchar seem to be > broken but they have their own locking (or lack thereof) in there own > lseek so its an internal proble,. > The other ones I found before giving up are drivers/s390/char/tape_char.c and drivers/sbus/char/flash.c. Arnd <><