From: Wolfgang Denk Date: Wed, 18 Nov 2009 23:21:58 +0100 Subject: [U-Boot] [PATCH V2 3/3] Add support for the LaCie ED Mini V2 board In-Reply-To: <1258239796-21528-4-git-send-email-albert.aribaud@free.fr> References: <1258239796-21528-1-git-send-email-albert.aribaud@free.fr> <1258239796-21528-2-git-send-email-albert.aribaud@free.fr> <1258239796-21528-3-git-send-email-albert.aribaud@free.fr> <1258239796-21528-4-git-send-email-albert.aribaud@free.fr> Message-ID: <20091118222158.A05573F6C2@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Albert Aribaud, In message <1258239796-21528-4-git-send-email-albert.aribaud@free.fr> you wrote: > This board is based on the Marvell Orion5x SoC. > Current support is limited to console and Flash. > Flash support uses LEGACY as the Macronix 29LV400 > used on ED Mini V2 is not 100% CFI compliant. And the differences are really so big that we cannot tweak the CFI driver? > +int dram_init(void) > +{ > + int i; > + > + for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) { > + gd->bd->bi_dram[i].start = orion5x_sdram_bar(i); > + gd->bd->bi_dram[i].size = orion5x_sdram_bs(i); > + } > + return 0; > +} Cannot you use get_ram_size() for auto-sizing and checking? > diff --git a/include/configs/edminiv2.h b/include/configs/edminiv2.h > new file mode 100644 > index 0000000..31de164 > --- /dev/null > +++ b/include/configs/edminiv2.h ... > +#define CONFIG_SYS_BAUDRATE_TABLE \ > +{ 9600, 19200, 38400, 57600, 115200, 230400, 460800, 921600 } Indentation by a TAB, please. > +#define CONFIG_SYS_FLASH_SECTSZ \ > +{16384, 8192, 8192, 32768, 65536, 65536, 65536, 65536, 65536, 65536, 65536} Ditto. And be careful about the line length. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de You get a wonderful view from the point of no return. - Terry Pratchett, _Making_Money_