From: Wolfgang Denk Date: Wed, 18 Nov 2009 23:42:06 +0100 Subject: [U-Boot] [PATCH V5 1/4] add TI DA8xx support: DA8xx includes In-Reply-To: <4B03BD0C.7080803@gefanuc.com> References: <4AF9823C.8090803@gefanuc.com> <0554BEF07D437848AF01B9C9B5F0BC5D93F2F002@dlee01.ent.ti.com> <20091117231047.75FF3F51B07@gemini.denx.de> <4B03BD0C.7080803@gefanuc.com> Message-ID: <20091118224206.0BA803F6C2@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Nick Thompson, In message <4B03BD0C.7080803@gefanuc.com> you wrote: > > I'm happy to submit a new patch to lowercase these enums if you > think that would be a good idea. It might be inviting trouble, > but I'm not aware of any outstanding patches that rely on these > values directly. I'm sorry, but I was actually wrong here. I missed the fact that it was an enum. And the "CodingStyle" says: "Names of macros defining constants and labels in enums are capitalized.' Sorry, my fault. I hereby withdraw my complaint and apologize for not being more careful. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Where would we be without rhetorical questions?