From: Mark Brown Subject: Re: [PATCH 09/19] drivers: serial: add support for Samsung S5PC110 SoC uart Date: Thu, 19 Nov 2009 11:08:27 +0000 Message-ID: <20091119110827.GE9763@rakim.wolfsonmicro.main> References: <1258551194-16018-1-git-send-email-m.szyprowski@samsung.com> <1258551194-16018-10-git-send-email-m.szyprowski@samsung.com> <1b68c6790911180614y355f656fs828177ecc845ec8e@mail.gmail.com> <20091118221345.GB4808@trinity.fluff.org> <1b68c6790911181844p3fb32525h11f79f942afb2d64@mail.gmail.com> <20091119103336.GB15460@sirena.org.uk> <1b68c6790911190305w33e777e3n1ed6b172d67f1639@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:39334 "EHLO opensource2.wolfsonmicro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750716AbZKSLIW (ORCPT ); Thu, 19 Nov 2009 06:08:22 -0500 Content-Disposition: inline In-Reply-To: <1b68c6790911190305w33e777e3n1ed6b172d67f1639@mail.gmail.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: jassi brar Cc: Ben Dooks , kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski On Thu, Nov 19, 2009 at 08:05:29PM +0900, jassi brar wrote: > On Thu, Nov 19, 2009 at 7:33 PM, Mark Brown > > This is going to set off warnings from a clock API point of view - > > passing clock names around in platform data is usually a sign that > > something is very wrong. =A0Keeping the mapping inside the clock AP= I > > (still controlled by the board driver but by telling the clock API = that > > device X should use clock Y). > no clock pointer needs to be passed, just a pointer to an array of _s= trings_ > There is no need to even include any clock header in platform code > for the purpose. Yes, that's what I was commenting on - like I say, passing clock names tends to set off the same alarm bells as passing a struct clk. Like I say, the general model for this has been that the fixups will be done b= y having the machine code talk to the clock API ratehr than bouncing the data about the clock to use through the driver.