Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NCwZ5-00061b-O2 for qemu-devel@nongnu.org; Tue, 24 Nov 2009 09:40:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NCwYy-0005wD-T6 for qemu-devel@nongnu.org; Tue, 24 Nov 2009 09:40:21 -0500 Received: from [199.232.76.173] (port=55820 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NCwYx-0005va-RV for qemu-devel@nongnu.org; Tue, 24 Nov 2009 09:40:16 -0500 Received: from mail-yw0-f171.google.com ([209.85.211.171]:36232) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NCwYx-0005Sl-Hd for qemu-devel@nongnu.org; Tue, 24 Nov 2009 09:40:15 -0500 Received: by ywh1 with SMTP id 1so5646452ywh.18 for ; Tue, 24 Nov 2009 06:40:14 -0800 (PST) Date: Tue, 24 Nov 2009 09:40:08 -0500 From: Kevin O'Connor Message-ID: <20091124144008.GA17606@morn.localdomain> References: <20091122140853.GI3193@redhat.com> <20091122170750.GB13491@morn.localdomain> <20091123110830.GE2999@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091123110830.GE2999@redhat.com> Subject: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org On Mon, Nov 23, 2009 at 01:08:30PM +0200, Gleb Natapov wrote: > > > - memcpy((char *)start, "CPU " "\0" "" "\0" "", 7); > > > - ((char *)start)[4] = cpu_number + '0'; > > > + memcpy((char *)start, "CPU \0QEMU\0\0", 12); > > > + ((char *)start)[4] = cpu_number + '0'; > > > > BTW, snprintf can now be used here. > > > snprintf in SeaBIOS doesn't have return value. In some situation it is > impossible to use it properly without it. It's straight forward to add - commit 2be312c1. -Kevin