From: Vincent Hanquez Subject: Re: [PATCH 09/14]: libxenlight, domain resume Date: Tue, 1 Dec 2009 06:18:22 +0000 Message-ID: <20091201061822.GC15791@gwig.uk.xensource.com> References: <4B1419C4.6010307@lagarcavilla.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <4B1419C4.6010307@lagarcavilla.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Andres Lagar-Cavilla Cc: "xen-devel@lists.xensource.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Mon, Nov 30, 2009 at 07:15:16PM +0000, Andres Lagar-Cavilla wrote: > Added libxenlight implementation for resume domain. > This brings back a domain from the shutdown state > after save, enabling checkpointing. (I haven't looks at resume stuff for age ..) I think this only works if the domain is cooperative, if it isn't you need to a callback in the middle of the calls to do devices related unplugging/plugging. If that still true, I would prefer to have a "if (pv)" around the code since pv are always suppose to be cooperative -- Vincent