From: Tim Deegan Subject: Re: [PATCH] cleanup for __start_xen() Date: Tue, 1 Dec 2009 09:42:17 +0000 Message-ID: <20091201094217.GI14284@whitby.uk.xensource.com> References: <4B146AAA.40508@cn.fujitsu.com> <4B146E75.7000802@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Return-path: Content-Disposition: inline In-Reply-To: <4B146E75.7000802@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Xiao Guangrong Cc: "xen-devel@lists.xensource.com" , Ian Jackson , Keir Fraser List-Id: xen-devel@lists.xenproject.org At 01:16 +0000 on 01 Dec (1259630197), Xiao Guangrong wrote: > e is moved in [e-(modules_length+modules_headroom), e] range, > so, s is not overrun e too... OK, but: - this is not obvious (hence this thread); - even Keir makes mistakes here from time to time; and - it's a single test on code that runs at start of day so maybe we should just leave it as it was? Cheers, Tim. -- Tim Deegan Principal Software Engineer, Citrix Systems (R&D) Ltd. [Company #02300071, SL9 0DZ, UK.]