From: Wolfgang Denk Date: Tue, 01 Dec 2009 22:15:45 +0100 Subject: [U-Boot] [PATCH] imx51:Add support basic boot code of freescale imx51 bbg board In-Reply-To: <2f495dc80912010844h6b4aa1e4i4588f808384b6272@mail.gmail.com> References: <12537172421605-git-send-email-fanyefeng@gmail.com> <20090923214720.67D18832E864@gemini.denx.de> <2f495dc80912010844h6b4aa1e4i4588f808384b6272@mail.gmail.com> Message-ID: <20091201211545.6CB53E6D391@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Fred Fan, In message <2f495dc80912010844h6b4aa1e4i4588f808384b6272@mail.gmail.com> you wrote: > > I almost fixed all of your comments. > By some of them I can not fix them now. > 1) Copyright block. It defined freescale other team. I can not change them > directly. I see. We will have to wait for this change, then. > 2) iomux module can not use C structure to access registers. Because > register has > encoded in to pin definition. I don't understand this statement. Why do you think this cannot be done with C structs and I/O accessors? > When I tested the new code on target board, I will send out to review > again. I'm looking forward to get this mainlined, but please fix all issues first. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Even if you can deceive people about a product through misleading statements, sooner or later the product will speak for itself. - Hajime Karatsu