From: Dmitry Torokhov Subject: Re: [RFC PATCH 2/2] Input: msi-wmi - switch to using sparse keymap library Date: Wed, 2 Dec 2009 10:48:42 -0800 Message-ID: <20091202184842.GB20530@core.coreip.homeip.net> References: <20091202192603.3e1de98a@destiny.ordissimo> <20091202192812.7e9919fb@destiny.ordissimo> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20091202192812.7e9919fb@destiny.ordissimo> Sender: linux-input-owner@vger.kernel.org To: Anisse Astier Cc: linux-input@vger.kernel.org, linux-acpi@vger.kernel.org, Len Brown , Carlos Corbacho List-Id: linux-acpi@vger.kernel.org On Wed, Dec 02, 2009 at 07:28:12PM +0100, Anisse Astier wrote: > > static void __exit msi_wmi_exit(void) Anisse, It does not look like you are freeing sparse keymap when you unnregistering input device, otherwise looks good. -- Dmitry