From: Wolfgang Denk Date: Wed, 02 Dec 2009 23:32:01 +0100 Subject: [U-Boot] [PATCH] SPI: Fix 32 bit transfers in mxc_spi.c In-Reply-To: <1257965907-5622-1-git-send-email-lilja.magnus@gmail.com> References: <1257965907-5622-1-git-send-email-lilja.magnus@gmail.com> Message-ID: <20091202223201.157174C025@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Guennadi, In message <1257965907-5622-1-git-send-email-lilja.magnus@gmail.com> Magnus Lilja wrote: > Commit f9b6a1575d9f1ca192e4cb60e547aa66f08baa3f, "i.MX31: fix SPI > driver for shorter than 32 bit" broke 32 bit transfers. This patch > makes single 32 bit transfer work again. > > Tested on i.MX31 Litekit and i.MX31 PDK using 32 bit transfers to > the MC13783/ATLAS chip (using the 'date' command). > > Signed-off-by: Magnus Lilja > Cc: Guennadi Liakhovetski > > --- > > I don't think transfers larger than 32 bits will work. It seems > like they worked in the original driver, but the above commit broke that. > This patch does not try to fix that problem. > > drivers/spi/mxc_spi.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c > index fad9840..8b5d4be 100644 > --- a/drivers/spi/mxc_spi.c > +++ b/drivers/spi/mxc_spi.c > @@ -142,6 +142,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout, > *(u8 *)din = data; > else if (bitlen < 17) > *(u16 *)din = data; > + else > + *in_l = data; > } > } Could you please comment ? Thanks in advance. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Many aligators will be slain, but the swamp will remain.