From: Kim Phillips Date: Fri, 4 Dec 2009 20:30:59 -0600 Subject: [U-Boot] [PATCH, REGRESSION] mpc83xx: provide option to set LCRR early In-Reply-To: <1258717363-19554-1-git-send-email-jacmet@sunsite.dk> References: <1258717363-19554-1-git-send-email-jacmet@sunsite.dk> Message-ID: <20091204203059.2d063610.kim.phillips@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, 20 Nov 2009 12:42:43 +0100 Peter Korsgaard wrote: > E.G. on a 8347 board a bootup time increase of ~600ms has been observed: heh, even more on an 8313! Thanks for this - I hadn't realized the difference was so large (or neglected it since the move to init_r was done at the last moment). > Fix it by introducing CONFIG_SYS_LCRR_EARLY, and set LCRR in cpu_init_f > instead of in cpu_init_r if set. instead of introducing the new CONFIG_SYS_LCRR_EARLY, shouldn't we check for something like: !defined(CONFIG_NAND_SPL) && !defined(CONFIG_SYS_RAMBOOT) ? > +++ b/cpu/mpc83xx/cpu_init.c > @@ -171,6 +171,30 @@ void cpu_init_f (volatile immap_t * im) > (CONFIG_SYS_SCCR_SATACM << SCCR_SATACM_SHIFT) | > #endif > 0; > +#ifdef CONFIG_SYS_LCRR_EARLY btw, this generates: cpu_init.c: In function 'cpu_init_r': cpu_init.c:367: warning: unused variable 'im' Kim