Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NHbee-0004Aw-LA for mharc-grub-devel@gnu.org; Mon, 07 Dec 2009 06:21:24 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NHbec-0004AA-OM for grub-devel@gnu.org; Mon, 07 Dec 2009 06:21:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NHbea-00049B-T7 for grub-devel@gnu.org; Mon, 07 Dec 2009 06:21:21 -0500 Received: from [199.232.76.173] (port=55492 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NHbea-00048t-IO for grub-devel@gnu.org; Mon, 07 Dec 2009 06:21:20 -0500 Received: from 74-93-104-97-washington.hfc.comcastbusiness.net ([74.93.104.97]:41381 helo=sunset.davemloft.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NHbea-000195-48 for grub-devel@gnu.org; Mon, 07 Dec 2009 06:21:20 -0500 Received: from localhost (localhost [127.0.0.1]) by sunset.davemloft.net (Postfix) with ESMTP id 1EF7B24C6E2; Mon, 7 Dec 2009 03:21:19 -0800 (PST) Date: Mon, 07 Dec 2009 03:21:18 -0800 (PST) Message-Id: <20091207.032118.35546400.davem@davemloft.net> To: grub-devel@gnu.org, phcoder@gmail.com From: David Miller In-Reply-To: <4B1CE174.30006@gmail.com> References: <20091206.224847.24234540.davem@davemloft.net> <4B1CE174.30006@gmail.com> X-Mailer: Mew version 6.2 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp-2 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Subject: Re: [PATCH]: Fix CDROM skipping in ieee1275 ofdisk iterator. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2009 11:21:23 -0000 From: Vladimir 'φ-coder/phcoder' Serbinenko Date: Mon, 07 Dec 2009 12:05:24 +0100 > Committed. > David Miller wrote: >> I tried to surmise other ways to do this more cleanly, such as >> resolving the path and looking for some device property inside of the >> resulting node, but there simply isn't anything we can check for. >> >> > If you find a cleaner way we can commit it later. I was thinking of > resolving path to hardware one and then querying hardware directly but > it may conflict with OF. What do you think? I don't think that is wise. We would then need two mappings, OF --> OS and OS --> OF for device naming. And all of that complexity for what? This silly cdrom issue where a simple strncmp() is solving the problem quite well so far? There are conventions for alias names created by default by the firmware, so we should be OK with the patch I have written here. > How much work would be needed to make ata.mod work on sparc64? Probably a lot. > Which other drivers we would need to reasonably replace ofdisk (which > would still be available as fallback)? I don't think it's worthwhile to break away from ofdisk, it works quite well.