From: Wolfgang Denk Date: Mon, 07 Dec 2009 13:07:54 +0100 Subject: [U-Boot] [PATCH] Fix debug output. In-Reply-To: <1260177679-18337-1-git-send-email-weber@corscience.de> References: <1260177679-18337-1-git-send-email-weber@corscience.de> Message-ID: <20091207120754.AE6EA3F6CC@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Thomas Weber, In message <1260177679-18337-1-git-send-email-weber@corscience.de> you wrote: > Signed-off-by: Thomas Weber > --- > drivers/net/dm9000x.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c > index 73dd335..08bd794 100644 > --- a/drivers/net/dm9000x.c > +++ b/drivers/net/dm9000x.c > @@ -74,8 +74,8 @@ TODO: external MII is not functional, only internal at the moment. > #define DM9000_DBG(fmt,args...) printf(fmt, ##args) > #define DM9000_DMP_PACKET(func,packet,length) \ > do { \ > - int i; \ > - printf(func ": length: %d\n", length); \ > + int i; \ > + printf("%s: length: %d\n",func, length); \ > for (i = 0; i < length; i++) { \ > if (i % 8 == 0) \ > printf("\n%s: %02x: ", func, i); \ Which problem is this supposed to fix? Actually this patch introduces two new issues (the "int i;" line uses spaces for indentation, and the '\' are not vertically aligned any more). NAK. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A girl with a future avoids the man with a past. -- Evan Esar, "The Humor of Humor"