From: Wolfgang Denk Date: Mon, 07 Dec 2009 22:38:33 +0100 Subject: [U-Boot] [PATCH] Fix computation in nand_util.c:get_len_incl_bad In-Reply-To: <1259672755-929-1-git-send-email-daniel.hobi@schmid-telecom.ch> References: <1259672755-929-1-git-send-email-daniel.hobi@schmid-telecom.ch> Message-ID: <20091207213833.B0E173F6CC@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Daniel Hobi, In message <1259672755-929-1-git-send-email-daniel.hobi@schmid-telecom.ch> you wrote: > Depending on offset, flash size and the number of bad blocks, > get_len_incl_bad may return a too small value which may lead to: > > 1) If there are no bad blocks, nand_{read,write}_skip_bad chooses the > bad block aware read/write code. This may hurt performance, but does > not have any adverse effects. > > 2) If there are bad blocks, the nand_{read,write}_skip_bad may choose > the bad block unaware read/write code (if len_incl_bad == *length) > which leads to corrupted data. > > Signed-off-by: Daniel Hobi > --- > @Scott: please review > @Wolfgang: please consider for 2009.11 > > diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Intelligence without character is a dangerous thing." - G. Steinem