From: David Miller Subject: Re: [PATCH v4] add the driver for Analog Devices Blackfin on-chip CAN controllers Date: Fri, 11 Dec 2009 15:17:35 -0800 (PST) Message-ID: <20091211.151735.11269330.davem@davemloft.net> References: <1260524788-13103-1-git-send-email-21cnbao@gmail.com> <4B22183F.2070806@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org, oe-pJ9TYRvN+WE@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org Return-path: In-Reply-To: <4B22183F.2070806-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: uclinux-dist-devel-bounces-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org Errors-To: uclinux-dist-devel-bounces-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b@public.gmane.org List-Id: netdev.vger.kernel.org From: Wolfgang Grandegger Date: Fri, 11 Dec 2009 11:00:31 +0100 > Barry Song wrote: >> Signed-off-by: Barry Song <21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> Signed-off-by: H.J. Oertel >> --- >> -v4: >> 1. request and release interrupts in open/close instead of in module load/unload >> 2. use bfin_read16/write16 instead of common readw/writew >> 3. fix "line over 80 characters" checkpatch warning >> 4. fix other coding style issues required by Wolfgang Grandegger > > David, here is my > > Signed-off-by: Wolfgang Grandegger Applied, thanks everyone.