Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NJu7D-0000Ix-5D for qemu-devel@nongnu.org; Sun, 13 Dec 2009 14:28:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NJu7B-0000IN-Hw for qemu-devel@nongnu.org; Sun, 13 Dec 2009 14:28:22 -0500 Received: from [199.232.76.173] (port=40085 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NJu7B-0000IK-CN for qemu-devel@nongnu.org; Sun, 13 Dec 2009 14:28:21 -0500 Received: from hall.aurel32.net ([88.191.82.174]:53789) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NJu7A-0000ov-Va for qemu-devel@nongnu.org; Sun, 13 Dec 2009 14:28:21 -0500 Date: Sun, 13 Dec 2009 20:28:15 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 1/7] alpha: Implement IMB; add placeholders for other userspace PALcalls. Message-ID: <20091213192815.GB4281@volta.aurel32.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Wed, Dec 09, 2009 at 03:38:40PM -0800, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > hw/alpha_palcode.c | 29 +++++++++++++++++++++++++++-- > 1 files changed, 27 insertions(+), 2 deletions(-) > > diff --git a/hw/alpha_palcode.c b/hw/alpha_palcode.c > index c48a297..44b2ca4 100644 > --- a/hw/alpha_palcode.c > +++ b/hw/alpha_palcode.c > @@ -1062,6 +1062,16 @@ void call_pal (CPUState *env, int palcode) > > qemu_log("%s: palcode %02x\n", __func__, palcode); > switch (palcode) { > + case 0x80: > + /* BPT */ > + qemu_log("BPT\n"); > + /* FIXME: Sends SIGTRAP, si_code=TRAP_BRKPT. */ > + exit(1); > + case 0x81: > + /* BUGCHK */ > + qemu_log("BUGCHK\n"); > + /* FIXME: Sends SIGTRAP, si_code=SI_FAULT. */ > + exit(1); > case 0x83: > /* CALLSYS */ > qemu_log("CALLSYS n " TARGET_FMT_ld "\n", env->ir[0]); > @@ -1076,6 +1086,11 @@ void call_pal (CPUState *env, int palcode) > env->ir[IR_V0] = -ret; > } > break; > + case 0x86: > + /* IMB */ > + qemu_log("IMB\n"); > + tb_flush(env); Is it really necessary to flush all the TB here? QEMU should already discard TB that have been modified. On other architecture this kind of memory barrier instruction is simply ignored. > + break; > case 0x9E: > /* RDUNIQUE */ > env->ir[IR_V0] = env->unique; > @@ -1086,9 +1101,19 @@ void call_pal (CPUState *env, int palcode) > env->unique = env->ir[IR_A0]; > qemu_log("WRUNIQUE: " TARGET_FMT_lx "\n", env->unique); > break; > + case 0xAA: > + /* GENTRAP */ > + qemu_log("GENTRAP: " TARGET_FMT_lx "\n", env->ir[IR_A0]); > + /* FIXME: This is supposed to send a signal: > + SIGFPE: > + GEN_INTOVF, GEN_INTDIV, GEN_FLTOVF, GEN_FLTDIV, > + GEN_FLTUND, GEN_FLTINV, GEN_FLTINE, GEN_ROPRAND > + SIGTRAP: > + others > + with various settings of si_code. */ > + exit(1); > default: > - qemu_log("%s: unhandled palcode %02x\n", > - __func__, palcode); > + qemu_log("%s: unhandled palcode %02x\n", __func__, palcode); > exit(1); > } > } > -- > 1.6.5.2 > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net