From: David Miller Date: Tue, 15 Dec 2009 07:15:34 +0000 Subject: Re: [PATCH] net: sh_eth alignment fix for sh7724 using NET_IP_ALIGN Message-Id: <20091214.231534.225225771.davem@davemloft.net> List-Id: References: <20091214103443.13082.84079.sendpatchset@rxone.opensource.se> <20091214.215753.147971281.davem@davemloft.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: magnus.damm@gmail.com Cc: netdev@vger.kernel.org, lethal@linux-sh.org, linux-sh@vger.kernel.org From: Magnus Damm Date: Tue, 15 Dec 2009 16:13:47 +0900 > Sorry about the confusion, but the #ifdef was actually intentional. =) > I can't find any description of the RPADIR register in the sh7724 data > sheet, but testing shows that the buffers are adjusted properly. So > since I don't know the register layout I prefer to optimize for the > known working combination of NET_IP_ALIGN = 2 and simply disable > .rpadir usage for other NET_IP_ALIGN cases. NET_IP_ALIGN is never != 2 on SUPERH SH_ETH depends on SUPERH It's a fantasy ifdef, of sorts. :-)