From: Mike Frysinger Date: Mon, 14 Dec 2009 08:58:18 -0500 Subject: [U-Boot] [PATCH 10/17] blackfin: Move appropriate cpu/ dirs to arch/blackfin/cpu/ In-Reply-To: <1260772760.18409.43.camel@ptyser-laptop> References: <1260745480-22442-1-git-send-email-ptyser@xes-inc.com> <200912140119.44922.vapier@gentoo.org> <1260772760.18409.43.camel@ptyser-laptop> Message-ID: <200912140858.19574.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 14 December 2009 01:39:20 Peter Tyser wrote: > > > Before I respin, do you have any issue with the fact that the > > > CFLAGS_lib will apply to both /lib and /arch/blackfin/lib? > > > > sorry, i dont understand what you mean. i must have missed the patch > > you're implicitly referring to ? > > I mentioned the issue briefly in the cover letter, but patch 2 is the > specific patch I'm referring to. Moving lib_generic/ to lib/ causes > changes like: > > diff --git a/board/bf518f-ezbrd/config.mk b/board/bf518f-ezbrd/config.mk > index f85bef5..e0c459e 100644 > --- a/board/bf518f-ezbrd/config.mk > +++ b/board/bf518f-ezbrd/config.mk > @@ -26,7 +26,7 @@ > # This is not actually used for Blackfin boards so do not change it > #TEXT_BASE = do-not-use-me > > -CFLAGS_lib_generic += -O2 > +CFLAGS_lib += -O2 > CFLAGS_lzma += -O2 > > So after my series, both lib/ and arch/blackfin/lib will be compiled > with the -O2 flag if I'm understanding the CLFAGS_xyz concept. > Previously, only lib_generic/ was compiled with -O2. Blackfin boards > are the only current users of the CFLAGS_ feature, so I thought you > might have some issues with the change:) yes, that is how the CFLAGS thing currently works. previously this was OK because there werent any like-named dirs in the tree so there wasnt any collision. i guess we can change the syntax so you have to give it the full- intree path ... shouldnt be a big deal. this one line change in config.mk: BCURDIR = $(CURDIR:$(obj)%=%) then you'd have to do CFLAGS_arch/blackfin/lib = -O2 -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20091214/f9b6fc7d/attachment.pgp