From: baruch@tkos.co.il (Baruch Siach) Date: Tue, 15 Dec 2009 08:08:45 +0200 Subject: [PATCH 3/4] fec: add support for Freescale i.MX25 PDK (3DS) In-Reply-To: <4B26E61F.7030709@snapgear.com> References: <4B26E61F.7030709@snapgear.com> Message-ID: <20091215060844.GA18290@jasper.tkos.co.il> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Greg, On Tue, Dec 15, 2009 at 11:27:59AM +1000, Greg Ungerer wrote: > Hi Baruch, > > Baruch Siach wrote: > >The i.MX25 PDK uses RMII to communicate with its PHY. This patch adds the > >necessary bits to make the i.MX25 talk RMII. > > > >Signed-off-by: Baruch Siach > >--- [snip] > >+ /* re-enable the gasket */ > >+ writel(2, fep->hwp + FEC_MIIGSK_ENR); > ^^^^^^^^^^^^^^ > > This will not compile for some CPU types that use this driver. > [snip] > >--- a/drivers/net/fec.h > >+++ b/drivers/net/fec.h > >@@ -43,6 +43,8 @@ > > #define FEC_R_DES_START 0x180 /* Receive descriptor ring */ > > #define FEC_X_DES_START 0x184 /* Transmit descriptor ring */ > > #define FEC_R_BUFF_SIZE 0x188 /* Maximum receive buff size */ > >+#define FEC_MIIGSK_CFGR 0x300 /* MIIGSK Configuration reg */ > >+#define FEC_MIIGSK_ENR 0x308 /* MIIGSK Enable reg */ > > These are defined in a conditional section for certain CPU types. > There is no definitions for the other "#else" section here. So, should I put a bogus #define in the other #else section, or put the FEC_MIIGSK_* code in an #ifdef section? I guess the latter is the way to go. baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -